Skip to content

fix: Load badge when requested - #16286

Merged
Artur- merged 1 commit into
mainfrom
load-badge
Mar 16, 2023
Merged

Artur- merged 1 commit into
mainfrom
load-badge

Conversation

@Artur-

@Artur- Artur- commented Mar 16, 2023

Copy link
Copy Markdown
Member

@Artur-
Artur- requested a review from mshabarov March 16, 2023 14:43
@mshabarov
mshabarov enabled auto-merge (squash) March 16, 2023 14:45
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Artur-
Artur- disabled auto-merge March 16, 2023 15:03
@Artur-
Artur- enabled auto-merge (squash) March 16, 2023 15:16
@github-actions

github-actions Bot commented Mar 16, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

   953 files  ±0     953 suites  ±0   57m 23s ⏱️ -58s
6 051 tests ±0  6 016 ✔️ ±0  35 💤 ±0  0 ❌ ±0 
6 298 runs  +4  6 256 ✔️ +4  42 💤 ±0  0 ❌ ±0 

Results for commit e007637. ± Comparison against base commit cadd59f.

♻️ This comment has been updated with latest results.

@Artur-
Artur- merged commit 14c12c4 into main Mar 16, 2023
@Artur-
Artur- deleted the load-badge branch March 16, 2023 17:28
vaadin-bot pushed a commit that referenced this pull request Mar 16, 2023
vaadin-bot added a commit that referenced this pull request Mar 16, 2023
Fixes vaadin/platform#3916

Co-authored-by: Artur <artur@vaadin.com>
Artur- added a commit that referenced this pull request Mar 22, 2023
mshabarov pushed a commit that referenced this pull request Mar 22, 2023
* Revert "fix: Load badge when requested (#16286) (#16288)"

This reverts commit e6a27e0.

* Revert "fix: Do not import Lumo twice for the document (#16243) (#16257)"

This reverts commit 29259ea.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Badge is missing from the default dev bundle

3 participants