Repository navigation
fix: Do not import Lumo twice for the document - #16243
Conversation
All Lumo modules except utility are loaded and injected into <head> by https://github.com/vaadin/flow-components/blob/main/vaadin-lumo-theme-flow-parent/vaadin-lumo-theme-flow/src/main/java/com/vaadin/flow/theme/lumo/Lumo.java We should not do that another time
|
This depends on #16230 for the test |
|
Scrap that, it does not need that test nor does it yet resolve #16231. That needs another PR |
mshabarov
left a comment
There was a problem hiding this comment.
Any test covering this patch?
…n/theme-generator.js Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
|
All existing tests that use Lumo pass so they should test that Lumo still works. I would not add a test that Lumo is not loaded twice because that tests the code and not any feature. The real problem that should be resolved is #16231, which has a disabled test in #16241. It can be fixed more easily once the test and this PR have been merged. It is an attempt to keep PRs reasonably sized |
|
Do we need this for 24.0? I think the theme loading changes that are needed are not in general suitable for a bugfix release |
Since this patch fixes what was recently added to 24.0, I assumed 24.0 deserves this fix, especially that the codebase is almost equivalent and this won't require any additional maintenance effort from us. |
Pull request was closed
|
Kudos, SonarCloud Quality Gate passed!
|
* fix: Do not import Lumo twice for the document All Lumo modules except utility are loaded and injected into <head> by https://github.com/vaadin/flow-components/blob/main/vaadin-lumo-theme-flow-parent/vaadin-lumo-theme-flow/src/main/java/com/vaadin/flow/theme/lumo/Lumo.java We should not do that another time * Update flow-server/src/main/resources/plugins/application-theme-plugin/theme-generator.js Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com> --------- Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
* fix: Do not import Lumo twice for the document All Lumo modules except utility are loaded and injected into <head> by https://github.com/vaadin/flow-components/blob/main/vaadin-lumo-theme-flow-parent/vaadin-lumo-theme-flow/src/main/java/com/vaadin/flow/theme/lumo/Lumo.java We should not do that another time * Update flow-server/src/main/resources/plugins/application-theme-plugin/theme-generator.js --------- Co-authored-by: Artur <artur@vaadin.com> Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>








All Lumo modules except utility are loaded and injected into by https://github.com/vaadin/flow-components/blob/main/vaadin-lumo-theme-flow-parent/vaadin-lumo-theme-flow/src/main/java/com/vaadin/flow/theme/lumo/Lumo.java We should not do that another time
This does not guarantee that the utility classes are injected before other styles but they are not meant to be overridden either