Skip to content

fix: Use correct path in Vite websocket requests - #17071

Merged
mcollovati merged 2 commits into
mainfrom
fix-vite-ws-path
Jun 21, 2023
Merged

mcollovati merged 2 commits into
mainfrom
fix-vite-ws-path

Conversation

@Artur-

@Artur- Artur- commented Jun 21, 2023

Copy link
Copy Markdown
Member

When the browser is using http://localhost:8888/context/view/VAADIN
and Vite is running on http://localhost:60075/context/view/VAADIN/
then the WS proxy request must go to http://localhost:60075/context/view/VAADIN/ and not http://localhost:60075/VAADIN/
@github-actions

github-actions Bot commented Jun 21, 2023 •

Copy link
Copy Markdown
Contributor

Test Results

   995 files  ±0     995 suites  ±0   1h 0m 34s ⏱️ +50s
6 332 tests ±0  6 291 ✔️ ±0  41 💤 ±0  0 ❌ ±0 
6 582 runs  +6  6 534 ✔️ +6  48 💤 ±0  0 ❌ ±0 

Results for commit 1a5de52. ± Comparison against base commit 97a890d.

♻️ This comment has been updated with latest results.

@Artur-
Artur- requested a review from mcollovati June 21, 2023 10:25
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mcollovati
mcollovati merged commit a029658 into main Jun 21, 2023
@mcollovati
mcollovati deleted the fix-vite-ws-path branch June 21, 2023 13:09
vaadin-bot pushed a commit that referenced this pull request Jun 21, 2023
When the browser is using http://localhost:8888/context/view/VAADIN
and Vite is running on http://localhost:60075/context/view/VAADIN/
then the WS proxy request must go to http://localhost:60075/context/view/VAADIN/ and not http://localhost:60075/VAADIN/
vaadin-bot added a commit that referenced this pull request Jun 21, 2023
When the browser is using http://localhost:8888/context/view/VAADIN
and Vite is running on http://localhost:60075/context/view/VAADIN/
then the WS proxy request must go to http://localhost:60075/context/view/VAADIN/ and not http://localhost:60075/VAADIN/

Co-authored-by: Artur <artur@vaadin.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.2.0.alpha1 and is also targeting the upcoming stable 24.2.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants