Skip to content

fix: Use correct path in Vite websocket requests (#17071) (CP: 24.1) - #17077

Merged
vaadin-bot merged 1 commit into
24.1from
cherry-pick-17071-to-24.1-1687356921040
Jun 21, 2023
Merged

vaadin-bot merged 1 commit into
24.1from
cherry-pick-17071-to-24.1-1687356921040

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

No description provided.

When the browser is using http://localhost:8888/context/view/VAADIN
and Vite is running on http://localhost:60075/context/view/VAADIN/
then the WS proxy request must go to http://localhost:60075/context/view/VAADIN/ and not http://localhost:60075/VAADIN/
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@vaadin-bot
vaadin-bot enabled auto-merge (squash) June 21, 2023 14:23
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

   993 files  ±0     993 suites  ±0   1h 1m 10s ⏱️ - 3m 50s
6 304 tests ±0  6 263 ✔️ ±0  41 💤 ±0  0 ❌ ±0 
6 557 runs  +9  6 509 ✔️ +9  48 💤 ±0  0 ❌ ±0 

Results for commit d818b62. ± Comparison against base commit f5367ff.

@vaadin-bot
vaadin-bot merged commit 0aa4ebb into 24.1 Jun 21, 2023
@vaadin-bot
vaadin-bot deleted the cherry-pick-17071-to-24.1-1687356921040 branch June 21, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants