Skip to content

fix: add missing registerStyles import to generated app-shell-imports.js (#23975) (CP: 25.1) - #24019

Merged
vaadin-bot merged 1 commit into
25.1from
cherry-pick-23975-to-25.1-1774522018495
Mar 26, 2026
Merged

vaadin-bot merged 1 commit into
25.1from
cherry-pick-23975-to-25.1-1774522018495

Conversation

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This PR cherry-picks changes from the original PR #23975 to branch 25.1.

Original PR description

The generated app-shell-imports.js file was missing the THEMABLE_MIXIN_IMPORT line (import { css, unsafeCSS, registerStyles }), causing ReferenceError: registerStyles is not defined at startup in production mode when @CssImport with themeFor was used on an AppShellConfigurator.

Also ensures import statements are moved to the top of the generated app shell file, consistent with other generated import files.

Fixes #23689

…ts.js (#23975)

The generated `app-shell-imports.js` file was missing the
`THEMABLE_MIXIN_IMPORT` line (`import { css, unsafeCSS, registerStyles }`),
causing `ReferenceError: registerStyles is not defined` at startup in
production mode when `@CssImport` with `themeFor` was used on an
`AppShellConfigurator`.

Also ensures import statements are moved to the top of the generated
app shell file, consistent with other generated import files.

Fixes #23689
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR [Message is sent from bot]

@vaadin-bot
vaadin-bot enabled auto-merge (squash) March 26, 2026 10:56
@vaadin-bot

Copy link
Copy Markdown
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically. If there are pending conditions, auto merge (with 'squash' method) has been enabled for this PR[Message is sent from bot]

@github-actions

Copy link
Copy Markdown
Contributor

Test Results

 1 386 files  ±0   1 386 suites  ±0   1h 23m 8s ⏱️ - 3m 46s
 9 927 tests +2   9 856 ✅ +2  71 💤 ±0  0 ❌ ±0 
10 400 runs  +2  10 320 ✅ +2  80 💤 ±0  0 ❌ ±0 

Results for commit 8312284. ± Comparison against base commit 4a30504.

@sonarqubecloud

Copy link
Copy Markdown

@vaadin-bot
vaadin-bot merged commit 6d71a70 into 25.1 Mar 26, 2026
29 of 30 checks passed
@vaadin-bot
vaadin-bot deleted the cherry-pick-23975-to-25.1-1774522018495 branch March 26, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants