Repository navigation
fix: add missing registerStyles import to generated app-shell-imports.js - #23975
Conversation
…ts.js
The generated `app-shell-imports.js` file was missing the
`THEMABLE_MIXIN_IMPORT` line (`import { css, unsafeCSS, registerStyles }`),
causing `ReferenceError: registerStyles is not defined` at startup in
production mode when `@CssImport` with `themeFor` was used on an
`AppShellConfigurator`.
Also ensures import statements are moved to the top of the generated
app shell file, consistent with other generated import files.
Fixes #23689
a838bbe to
95dcb2a
Compare
|
…ts.js (#23975) The generated `app-shell-imports.js` file was missing the `THEMABLE_MIXIN_IMPORT` line (`import { css, unsafeCSS, registerStyles }`), causing `ReferenceError: registerStyles is not defined` at startup in production mode when `@CssImport` with `themeFor` was used on an `AppShellConfigurator`. Also ensures import statements are moved to the top of the generated app shell file, consistent with other generated import files. Fixes #23689
|
Hi @mcollovati and @mcollovati, when i performed cherry-pick to this commit to 25.0, i have encountered the following issue. Can you take a look and pick it manually? |
…ts.js (#23975) The generated `app-shell-imports.js` file was missing the `THEMABLE_MIXIN_IMPORT` line (`import { css, unsafeCSS, registerStyles }`), causing `ReferenceError: registerStyles is not defined` at startup in production mode when `@CssImport` with `themeFor` was used on an `AppShellConfigurator`. Also ensures import statements are moved to the top of the generated app shell file, consistent with other generated import files. Fixes #23689
…ts.js (#23975) (#24019) The generated `app-shell-imports.js` file was missing the `THEMABLE_MIXIN_IMPORT` line (`import { css, unsafeCSS, registerStyles }`), causing `ReferenceError: registerStyles is not defined` at startup in production mode when `@CssImport` with `themeFor` was used on an `AppShellConfigurator`. Also ensures import statements are moved to the top of the generated app shell file, consistent with other generated import files. Fixes #23689 Co-authored-by: Marco Collovati <marco@vaadin.com>
…ts.js (#23975) (#24020) The generated `app-shell-imports.js` file was missing the `THEMABLE_MIXIN_IMPORT` line (`import { css, unsafeCSS, registerStyles }`), causing `ReferenceError: registerStyles is not defined` at startup in production mode when `@CssImport` with `themeFor` was used on an `AppShellConfigurator`. Also ensures import statements are moved to the top of the generated app shell file, consistent with other generated import files. Fixes #23689



The generated
app-shell-imports.jsfile was missing theTHEMABLE_MIXIN_IMPORTline (import { css, unsafeCSS, registerStyles }), causingReferenceError: registerStyles is not definedat startup in production mode when@CssImportwiththemeForwas used on anAppShellConfigurator.Also ensures import statements are moved to the top of the generated app shell file, consistent with other generated import files.
Fixes #23689