Skip to content

fix: add missing registerStyles import to generated app-shell-imports.js (#23975) (CP: 25.0) - #24020

Merged
caalador merged 1 commit into
25.0from
cherry/cherrypick-23975-to-25.0
Mar 26, 2026
Merged

caalador merged 1 commit into
25.0from
cherry/cherrypick-23975-to-25.0

Conversation

@mcollovati

Copy link
Copy Markdown
Collaborator

The generated app-shell-imports.js file was missing the THEMABLE_MIXIN_IMPORT line (import { css, unsafeCSS, registerStyles }), causing ReferenceError: registerStyles is not defined at startup in production mode when @CssImport with themeFor was used on an AppShellConfigurator.

Also ensures import statements are moved to the top of the generated app shell file, consistent with other generated import files.

Fixes #23689

…ts.js (#23975)

The generated `app-shell-imports.js` file was missing the
`THEMABLE_MIXIN_IMPORT` line (`import { css, unsafeCSS, registerStyles }`),
causing `ReferenceError: registerStyles is not defined` at startup in
production mode when `@CssImport` with `themeFor` was used on an
`AppShellConfigurator`.

Also ensures import statements are moved to the top of the generated
app shell file, consistent with other generated import files.

Fixes #23689
@caalador
caalador enabled auto-merge (squash) March 26, 2026 11:07
@github-actions

Copy link
Copy Markdown
Contributor

Test Results

1 317 files  ±0  1 317 suites  ±0   1h 20m 54s ⏱️ + 1m 16s
9 343 tests +2  9 275 ✅ +2  68 💤 ±0  0 ❌ ±0 
9 789 runs   - 9  9 713 ✅  - 9  76 💤 ±0  0 ❌ ±0 

Results for commit 8d24e8e. ± Comparison against base commit 9a451e4.

@sonarqubecloud

Copy link
Copy Markdown

@caalador
caalador merged commit 868857d into 25.0 Mar 26, 2026
30 of 31 checks passed
@caalador
caalador deleted the cherry/cherrypick-23975-to-25.0 branch March 26, 2026 11:33
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 25.0.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants