Repository navigation
fix: add missing registerStyles import to generated app-shell-imports.js (#23975) (CP: 25.0) - #24020
Merged
Merged
Conversation
…ts.js (#23975) The generated `app-shell-imports.js` file was missing the `THEMABLE_MIXIN_IMPORT` line (`import { css, unsafeCSS, registerStyles }`), causing `ReferenceError: registerStyles is not defined` at startup in production mode when `@CssImport` with `themeFor` was used on an `AppShellConfigurator`. Also ensures import statements are moved to the top of the generated app shell file, consistent with other generated import files. Fixes #23689
caalador
approved these changes
Mar 26, 2026
caalador
enabled auto-merge (squash)
March 26, 2026 11:07
Contributor
|
Collaborator
|
This ticket/PR has been released with Vaadin 25.0.9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The generated
app-shell-imports.jsfile was missing theTHEMABLE_MIXIN_IMPORTline (import { css, unsafeCSS, registerStyles }), causingReferenceError: registerStyles is not definedat startup in production mode when@CssImportwiththemeForwas used on anAppShellConfigurator.Also ensures import statements are moved to the top of the generated app shell file, consistent with other generated import files.
Fixes #23689