Skip to content

Migrate vaadin-button to use new base class #2224

Closed

Description

@web-padawan

Motivation

This is a second part of updating vaadin-button to use new DOM structure.

Depends on #2223
Part of #84

Proposed solution

  1. Add Lumo and Material theme to new package (styles to be discussed with Jouni).
  2. Add custom element definition to vaadin-button base class located in the new package.
  3. Remove old implementation, keep the imports and make them load the new package.
  4. Once the new package is published, update Flow counterpart to use it instead of the old one.

Note

Write down all the changes to themes (especially relevant for Lumo) using diff format.

Related a11y issues

See #153 (button is listed among other components), #600, #866.

Activity

  1. self-assigned this
    on Aug 17, 2021
  2. web-padawan commented on Aug 31, 2021

    @web-padawan
    MemberAuthor

    Done in #2411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions