Skip to content

Tooltip text is barely visible on dark mode #4648

Closed

Description

@tomivirkki

Description

Tooltip text is barely visible on dark mode:

Screenshot 2022-09-28 at 16 38 47

Expected outcome

The contrast on dark mode should be sufficient

Minimal reproducible example

See https://vaadin.com/docs/latest/components/tooltip

Steps to reproduce

Hover over a text-field to show a tooltip

Environment

Vaadin version(s): 23.3.0-alpha1

Browsers

Issue is not browser related

Activity

  1. jouni commented on Sep 28, 2022

    @jouni
    Member

    Do I remember wrong, or did we agree to use non-inverted colors in both light and dark versions of the tooltip? I mean, use --lumo-base-color + --lumo-contrast-5pct for the background and --lumo-body-text-color for the text color?

  2. web-padawan commented on Sep 28, 2022

    @web-padawan
    Member

    Yes, I think we discussed it, sorry about forgetting to apply this change. I will make a PR with visual tests.

  3. self-assigned this
    on Sep 30, 2022
  4. web-padawan commented on Oct 4, 2022

    @web-padawan
    Member

    Fixed by #4655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions