Skip to content

refactor: update tooltip colors, fix dark theme - #4655

Merged
web-padawan merged 3 commits into
masterfrom
fix/dark-theme
Oct 1, 2022
Merged

web-padawan merged 3 commits into
masterfrom
fix/dark-theme

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Updated Lumo tooltip to use non-inverted colors as suggested in #4648 (comment), added dark mode tests.

Type of change

  • Refactor

@web-padawan
web-padawan requested a review from jouni September 30, 2022 08:14
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit 29a5515 into master Oct 1, 2022
@web-padawan
web-padawan deleted the fix/dark-theme branch October 1, 2022 07:27
@knoobie

knoobie commented Oct 1, 2022

Copy link
Copy Markdown
Contributor

Personally I think the tooltip should be dark even on light mode 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants