Skip to content

[confirm-dialog] Rename boolean properties to align with naming conventions #597

Closed

Description

@web-padawan

The following properties are not self-descriptive and could be renamed:

  • reject -> rejectButtonVisible
  • cancel-> cancelButtonVisible

This would make them aligned with clearButtonVisible and revealButtonHidden.

Activity

  1. changed the title [-]Rename boolean properties to align with naming conventions[/-] [+][confirm-dialog] Rename boolean properties to align with naming conventions[/+] on May 20, 2021
  2. self-assigned this
    on Dec 19, 2022
  3. tomivirkki commented on Dec 20, 2022

    @tomivirkki
    Member

    Should the same naming alignment be done in flow-components?

    textField.setClearButtonVisible(true);
    passwordField.setRevealButtonVisible(true);
    
    confirmDialog.setRejectable(true);
    confirmDialog.setCancelable(true);
  4. web-padawan commented on Dec 20, 2022

    @web-padawan
    MemberAuthor

    We should have considered this before, now it's too late to deprecate existing methods as 23.3.0 is already stable 😕
    IMO for now we can keep these methods as they are - there are already lots of breaking changes in V24 anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions