Skip to content

refactor!: rename cancel and reject properties of confirm dialog - #5136

Merged
web-padawan merged 4 commits into
masterfrom
597-confirm-dialog-rename-boolean-properties-to-align-with-naming-conventions
Dec 20, 2022
Merged

web-padawan merged 4 commits into
masterfrom
597-confirm-dialog-rename-boolean-properties-to-align-with-naming-conventions

Conversation

@ugur-vaadin

Copy link
Copy Markdown
Contributor

Description

The following properties for confirm dialog were renamed:

  • reject -> rejectButtonVisible
  • cancel -> cancelButtonVisible

This is a breaking change.

Fixes #597

Type of change

  • Bugfix
  • Feature
  • Refactor

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan web-padawan changed the title refactor: rename cancel and reject properties of confirm dialog refactor!: rename cancel and reject properties of confirm dialog Dec 20, 2022
@web-padawan
web-padawan removed the request for review from tomivirkki December 20, 2022 08:00
@web-padawan
web-padawan merged commit ee7af54 into master Dec 20, 2022
@web-padawan
web-padawan deleted the 597-confirm-dialog-rename-boolean-properties-to-align-with-naming-conventions branch December 20, 2022 08:01
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.0.alpha7 and is also targeting the upcoming stable 24.0.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[confirm-dialog] Rename boolean properties to align with naming conventions

3 participants