You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[context-menu] Menu items do not follow public styling API conventions #795
The following selectors should be considered internal implementation details (e.g. ::slotted(.vaadin-menu-item)), yet they apply styles which belong to a theme:
Any custom theme that wants to for example customize the sub-menu indicator (content: var(--lumo-icons-angle-right);) will need to override an unsupported selector :host(.vaadin-menu-item.vaadin-context-menu-parent-item)::after, which is not guaranteed to be backwards compatible.
changed the title [-]Menu items do not follow public styling API conventions[/-][+][context-menu] Menu items do not follow public styling API conventions[/+]on May 28, 2021
(and I should try to remember to not link to source lines in master, because those will inevitably change).
Edit: updated, linked to the lines at the time of creating this issue.
Activity
[-]Menu items do not follow public styling API conventions[/-][+][context-menu] Menu items do not follow public styling API conventions[/+]rolfsmeds commentedon Sep 14, 2022
Not sure I ge this – why is the
.vaadin-menu-itemclassname applied and used in those selectors?jouni commentedon Sep 15, 2022
I assume in order to target any kind of
vaadin-*-item, and not need to explicitly list all the different types.jouni commentedon Sep 15, 2022
(and I should try to remember to not link to source lines in
master, because those will inevitably change).Edit: updated, linked to the lines at the time of creating this issue.
web-padawan commentedon Oct 20, 2022
These class names were added in vaadin/vaadin-context-menu#200 where
vaadin-itemelement was used. Later on, we changed to usevaadin-context-menu-itemin vaadin/vaadin-context-menu#213 but did not remove those class names.Let's fix this in V24 by removing usage of
.vaadin-menu-itemas it's no longer needed.