Repository navigation
refactor!: remove class names from list-box and items - #5111
Merged
Merged
Conversation
tomivirkki
approved these changes
Dec 8, 2022
web-padawan
commented
Dec 8, 2022
| 'vaadin-context-menu-list-box', | ||
| css` | ||
| :host(.vaadin-menu-list-box) { | ||
| :host { |
Member
Author
There was a problem hiding this comment.
Adding specificity here isn't needed, see #795 (comment)
| cursor: default; | ||
| } | ||
|
|
||
| [part='items'] ::slotted(.vaadin-menu-item) { |
Member
Author
There was a problem hiding this comment.
Merged two blocks of rules using duplicate CSS selectors into a single one.
Comment on lines
-70
to
-72
| :host(.vaadin-menu-item)::before { | ||
| display: block; | ||
| } |
Member
Author
There was a problem hiding this comment.
This CSS is no longer working after we introduced part="checkmark", removed.
web-padawan
force-pushed
the
refactor/context-menu-class-remove
branch
from
December 8, 2022 13:32
fb6af63 to
3e3eda3
Compare
web-padawan
force-pushed
the
refactor/context-menu-class-remove
branch
from
December 8, 2022 13:47
10ba3b9 to
908dd78
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Collaborator
|
This ticket/PR has been released with Vaadin 24.0.0.alpha7 and is also targeting the upcoming stable 24.0.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Fixes #795
vaadin-context-menulist-box and items when usingitemsAPI,role="menuitem"andaria-haspopupattributes instead.Type of change