Skip to content

refactor: revert button container - #2402

Merged
web-padawan merged 1 commit into
masterfrom
refactor/revert-button-container
Aug 27, 2021
Merged

web-padawan merged 1 commit into
masterfrom
refactor/revert-button-container

Conversation

@vursen

@vursen vursen commented Aug 27, 2021 •

Copy link
Copy Markdown
Contributor

Description

Decided not to introduce the [part=button] part and revert the .vaadin-button-container class in the new @vaadin/button package.

Part of #2224

Type of change

  • Internal change

Checklist

  • I have read the contribution guide: https://vaadin.com/docs-beta/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@vursen
vursen requested a review from web-padawan August 27, 2021 07:56
@web-padawan
web-padawan merged commit 087dc7f into master Aug 27, 2021
@web-padawan
web-padawan deleted the refactor/revert-button-container branch August 27, 2021 07:58
@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants