Repository navigation
fix: clear selection on clear button touchend - #4141
Merged
Merged
Conversation
sissbruecker
approved these changes
Jul 8, 2022
web-padawan
force-pushed
the
fix/msc-clear-touchend
branch
from
July 8, 2022 08:05
c1bd24d to
b1281de
Compare
web-padawan
marked this pull request as ready for review
July 8, 2022 08:08
|
Kudos, SonarCloud Quality Gate passed!
|
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 8, 2022
web-padawan
added a commit
that referenced
this pull request
Jul 8, 2022
web-padawan
added a commit
that referenced
this pull request
Jul 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
Fixes #4129
Depends on #4140
Created a separate event listener for clear button
touchendevent to callclear()on the host element.The internal combo-box also has a
touchendlistener, but it only clears<input>value.We might simplify this logic in the future as part of #4130 by moving the listener to
InputControlMixin.Type of change