Skip to content

fix: clear selection on clear button touchend - #4141

Merged
web-padawan merged 1 commit into
masterfrom
fix/msc-clear-touchend
Jul 8, 2022
Merged

web-padawan merged 1 commit into
masterfrom
fix/msc-clear-touchend

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Fixes #4129
Depends on #4140

Created a separate event listener for clear button touchend event to call clear() on the host element.
The internal combo-box also has a touchend listener, but it only clears <input> value.

We might simplify this logic in the future as part of #4130 by moving the listener to InputControlMixin.

Type of change

  • Bugfix

@web-padawan
web-padawan force-pushed the fix/msc-clear-touchend branch from c1bd24d to b1281de Compare July 8, 2022 08:05
@web-padawan
web-padawan marked this pull request as ready for review July 8, 2022 08:08
@sonarqubecloud

sonarqubecloud Bot commented Jul 8, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@web-padawan
web-padawan merged commit f570a3c into master Jul 8, 2022
@web-padawan
web-padawan deleted the fix/msc-clear-touchend branch July 8, 2022 08:09
web-padawan added a commit that referenced this pull request Jul 8, 2022
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[multi-select-combo-box] Clear button does not work on iOS

3 participants