Skip to content

fix: do not allow any interaction when disabled - #4668

Merged
web-padawan merged 1 commit into
masterfrom
fix/date-time-picker/do-not-let-user-interact-with-disabled-control
Oct 3, 2022
Merged

web-padawan merged 1 commit into
masterfrom
fix/date-time-picker/do-not-let-user-interact-with-disabled-control

Conversation

@vursen

@vursen vursen commented Oct 3, 2022 •

Copy link
Copy Markdown
Contributor

Description

date-time-picker sets pointer-events: all on its child pickers which results in them reacting to hover when disabled. The original PR doesn't give any clue why pointer-events was necessary, nor did I come up with any use case for it, so I believe they can be removed.

Fixes #4344

Type of change

  • Bugfix

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

@sonarqubecloud

sonarqubecloud Bot commented Oct 3, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vursen
vursen marked this pull request as ready for review October 3, 2022 13:16
@vursen
vursen requested a review from web-padawan October 3, 2022 13:16
@web-padawan

Copy link
Copy Markdown
Member

This CSS was added in vaadin/vaadin-date-time-picker@300fa01 and I have no idea why it was needed 🤷‍♂️

@web-padawan
web-padawan merged commit bca7ca3 into master Oct 3, 2022
@web-padawan
web-padawan deleted the fix/date-time-picker/do-not-let-user-interact-with-disabled-control branch October 3, 2022 13:50
web-padawan pushed a commit that referenced this pull request Oct 3, 2022
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
web-padawan pushed a commit that referenced this pull request Oct 3, 2022
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
web-padawan pushed a commit that referenced this pull request Oct 4, 2022
Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

date-time-picker does not disable hover/cursor styling when disabled

3 participants