Repository navigation
fix: do not allow any interaction when disabled - #4668
Merged
web-padawan merged 1 commit intoOct 3, 2022
Merged
web-padawan merged 1 commit into
web-padawan merged 1 commit into
Conversation
|
Kudos, SonarCloud Quality Gate passed! |
vursen
marked this pull request as ready for review
October 3, 2022 13:16
Member
|
This CSS was added in vaadin/vaadin-date-time-picker@300fa01 and I have no idea why it was needed 🤷♂️ |
web-padawan
approved these changes
Oct 3, 2022
web-padawan
deleted the
fix/date-time-picker/do-not-let-user-interact-with-disabled-control
branch
October 3, 2022 13:50
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Oct 3, 2022
web-padawan
pushed a commit
that referenced
this pull request
Oct 3, 2022
web-padawan
pushed a commit
that referenced
this pull request
Oct 3, 2022
web-padawan
pushed a commit
that referenced
this pull request
Oct 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
date-time-pickersetspointer-events: allon its child pickers which results in them reacting to hover when disabled. The original PR doesn't give any clue whypointer-eventswas necessary, nor did I come up with any use case for it, so I believe they can be removed.Fixes #4344
Type of change
Checklist