Skip to content

refactor: remove a unnecessary clear() method override - #5515

Merged
web-padawan merged 1 commit into
mainfrom
refactor/remove-unnecessary-override
Feb 9, 2023
Merged

web-padawan merged 1 commit into
mainfrom
refactor/remove-unnecessary-override

Conversation

@vursen

@vursen vursen commented Feb 9, 2023 •

Copy link
Copy Markdown
Contributor

Description

The clear() method override is unnecessary. The original InputMixin.clear() method already clears the input element's value. It is apparently a leftover from some early refactorings.

Type of change

  • Refactor

@sonarqubecloud

sonarqubecloud Bot commented Feb 9, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vursen
vursen marked this pull request as ready for review February 9, 2023 14:48
@vursen vursen changed the title refactor: remove an unnecessary clear() override refactor: remove an unnecessary clear() method override Feb 9, 2023
@vursen vursen changed the title refactor: remove an unnecessary clear() method override refactor: remove a unnecessary clear() method override Feb 9, 2023

@web-padawan web-padawan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the override is no longer necessary after #4864 was merged.

@web-padawan
web-padawan merged commit 026cecd into main Feb 9, 2023
@web-padawan
web-padawan deleted the refactor/remove-unnecessary-override branch February 9, 2023 19:37
web-padawan pushed a commit that referenced this pull request Feb 9, 2023
)

Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants