Skip to content

fix: TypeScript typings for clearButtonVisible prop in field components (CP: 24.0) - #5758

Merged
sissbruecker merged 1 commit into
24.0from
fix/clear_button_visible_24.0
Apr 17, 2023
Merged

sissbruecker merged 1 commit into
24.0from
fix/clear_button_visible_24.0

Conversation

@sissbruecker

Copy link
Copy Markdown
Member

Cherry-pick of #5754

@sonarqubecloud

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@platosha

Copy link
Copy Markdown
Contributor

Hm-m, the CI reported visual test errors for Lumo, but they seem to be irrelevant: only small differences in border and font rendering inside the CRUD dialog. Any ways to fix or suppress these?

ltr-editor-position-default-edit-diff
rtl-editor-position-fullscreen-new-diff

@sissbruecker

Copy link
Copy Markdown
Member Author

Visual tests are a bit flaky, most likely due to differences in the environments provided by Sauce Labs. We usually just re-run the jobs and see if that helps.

@sissbruecker
sissbruecker merged commit 014beac into 24.0 Apr 17, 2023
@sissbruecker
sissbruecker deleted the fix/clear_button_visible_24.0 branch April 17, 2023 10:23
@vaadin-bot

Copy link
Copy Markdown
Collaborator

Hi @sissbruecker , this commit cannot be picked to 23.3 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 014beac
error: could not apply 014beac... fix: TypeScript typings for clearButtonVisible prop in field components (CP: 24.0) (#5758)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.0.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants