Repository navigation
refactor: make combo-box use DataProviderController - #7044
Conversation
3fbad4a to
b3e1d14
Compare
e96006a to
223e39f
Compare
5e2e3bf to
ab03e1e
Compare
|
ab03e1e to
34ecc64
Compare
1418504 to
f08d006
Compare
73cc8c8 to
9957d9c
Compare
bd70e58 to
065f12b
Compare
630a74a to
d8a450b
Compare
33d13ba to
8963067
Compare
fcbea2c to
9e4b5e2
Compare
| throw new Error('`pageSize` value must be an integer > 0'); | ||
| } | ||
|
|
||
| this.__dataProviderController.setPageSize(pageSize); |
There was a problem hiding this comment.
nit: looks like all the tests pass with clearCache() line below being removed.
But this also happens on main so not related to this PR, can be ignored.
There was a problem hiding this comment.
Good catch, but yeah, I think we could improve this separately. To be safe, I tested it manually and it works in both WC and Flow.
add3e15 to
a022592
Compare
wip wip remove hasData API from DataProviderController get rid of page-received fix JSDoc add isPlaceholder for backward compatibility reduce diff fix tests remove unnecessary this binding revert some changes, add more tests wip wip update data provider controller tests minimize diff revert incorrect change after rebase minimize diff remove extra checks improve JSDoc fix corner case, add test enhance JSDoc fix tests reassign cache items to trigger filteredItems observer add code comments fix wip revert check for size from setPage fix failing tests remove unnecessary check revert unnecessary changes use logical assignment operator make data provider controller properties and listeners private
d6318fc to
b4c7985
Compare
There was a problem hiding this comment.
note: The new logic in DataProviderController lacks individual test coverage. I plan to add such tests in a separate iteration after this PR is merged.
|
|
This ticket/PR has been released with Vaadin 24.5.0.alpha4 and is also targeting the upcoming stable 24.5.0 version. |




Description
This PR refactors the combo-box to use DataProviderController. The refactoring is expected to be non-breaking and fully compatible with the existing ComboBox Flow connector, which is verified by successfully passing all the Flow integration tests.
Depends on
Type of change