Repository navigation
fix: always close select on outside click when in modeless dialog - #8727
Merged
Merged
Conversation
|
sissbruecker
approved these changes
Feb 25, 2025
vaadin-bot
pushed a commit
that referenced
this pull request
Feb 25, 2025
web-padawan
added a commit
that referenced
this pull request
Feb 25, 2025
) (#8730) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Collaborator
|
This ticket/PR has been released with Vaadin 24.7.0.beta1 and is also targeting the upcoming stable 24.7.0 version. |
Collaborator
|
This ticket/PR has been released with Vaadin 24.8.0.alpha1 and is also targeting the upcoming stable 24.8.0 version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes vaadin/flow-components#7139
See vaadin/flow-components#7139 (comment) for some clarification on how
_lastflag used by the default implementation of_shouldCloseOnOutsideClick()affectsvaadin-selectwhen inside of a modelessvaadin-dialogon header click.Note: we could instead try to adapt #8692, but IMO the proposed fix is much simpler (and aligned with combo-box etc).
Type of change