Skip to content

fix: always close select on outside click when in modeless dialog - #8727

Merged
web-padawan merged 1 commit into
mainfrom
fix/select-outside-click-modeless-dialog
Feb 25, 2025
Merged

web-padawan merged 1 commit into
mainfrom
fix/select-outside-click-modeless-dialog

Conversation

@web-padawan

Copy link
Copy Markdown
Member

Description

Fixes vaadin/flow-components#7139

See vaadin/flow-components#7139 (comment) for some clarification on how _last flag used by the default implementation of _shouldCloseOnOutsideClick() affects vaadin-select when inside of a modeless vaadin-dialog on header click.

Note: we could instead try to adapt #8692, but IMO the proposed fix is much simpler (and aligned with combo-box etc).

Type of change

  • Bugfix

@sonarqubecloud

Copy link
Copy Markdown

@web-padawan
web-padawan removed the request for review from vursen February 25, 2025 08:01
@web-padawan
web-padawan merged commit faeab89 into main Feb 25, 2025
@web-padawan
web-padawan deleted the fix/select-outside-click-modeless-dialog branch February 25, 2025 08:02
web-padawan added a commit that referenced this pull request Feb 25, 2025
) (#8730)

Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.7.0.beta1 and is also targeting the upcoming stable 24.7.0 version.

@vaadin-bot

Copy link
Copy Markdown
Collaborator

This ticket/PR has been released with Vaadin 24.8.0.alpha1 and is also targeting the upcoming stable 24.8.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vaadin select doesn't close properly when click on a modeless dialog header

3 participants