Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vaadin/flow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 24.0.0
Choose a base ref
...
head repository: vaadin/flow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 24.0.1
Choose a head ref
  • 20 commits
  • 60 files changed
  • 10 contributors

Commits on Mar 8, 2023

  1. test: Do not install chromedriver in build (#16200) (#16203)

    Co-authored-by: Artur <artur@vaadin.com>
    vaadin-bot and Artur- authored Mar 8, 2023
    Configuration menu
    Copy the full SHA
    a91fbfb View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. chore: Align Flow test dev bundle with the default dev bundle in plat…

    …form (#16153)
    
    * chore: Align Flow test dev bundle with the default dev bundle in platform
    
    * remove the module checking line-awesome is in default bundle
    
    * remove polymer and line-awesome packages
    
    ---------
    
    Co-authored-by: Artur <artur@vaadin.com>
    Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com>
    3 people authored Mar 9, 2023
    Configuration menu
    Copy the full SHA
    2781448 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. chore: Update to TestBench 9.0.1 (#16217) (#16220)

    Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
    vaadin-bot and mshabarov authored Mar 10, 2023
    Configuration menu
    Copy the full SHA
    6713c92 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2023

  1. fix: Add missing provided scope (#16221) (#16232)

    Fixes vaadin/platform#3898
    
    Co-authored-by: Artur <artur@vaadin.com>
    vaadin-bot and Artur- authored Mar 11, 2023
    Configuration menu
    Copy the full SHA
    609e66a View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. fix: option key does not work in addClickShortCut() method (#16086) (#…

    …16250)
    
    * Investigations comments to relevant parts.
    * formatted files with mvn formatter:format
    * added potential solution, need to add covering tests as well (for triggering Alt, AltGraph, both of them shall work).
    * removing comments, and potential solutions which will not be used anymore.
    * Cleaned up comments to make it cleaner (ShortcutRegistration)
    - Added tests in ShortcutEventTest and created a new test class for testing filterText generation ShortCutRegistrationFilterText,
    - Some smaller comment/typo fixes in (Shortcuts),
    - Changed the fix itself as the tests show it is not handling all the cases properly
    * mvn formatter:format executed.
    *fix test name typo.
    * assertFalse refactor went wrong (double negation), I used assertTrue and forgot to remove the !.
    Now it shall be good!
    * after manual testing the code was fixed.
    * fix the tests for covering the changes that happened in ShortCutRegistration.
    * mvn formatter:format run once again.
    * added JavaDoc for the test Reflection used util methods, and some small refactor to have inline variable.
    * mvn formatter:format run once again + some new asserts in tets as well.
    * cleanup the code based on Tepi's review, idea! (Thanks!)
    * "&&&&".split("&&", Integer.MAX_VALUE) -> this will give back ["", "", ""], but without the second parameter, it would have not found these... So with this fix, we will cover more cases.
    (https://stackoverflow.com/questions/18815911/string-split-and-dealing-with-duplicates)
    * minor cleanup (Teppo)
    ---------
    Co-authored-by: Teppo Kurki <teppo.kurki@vaadin.com>
    
    Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com>
    vaadin-bot and czp13 authored Mar 13, 2023
    Configuration menu
    Copy the full SHA
    f9e8802 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. fix: Do not import Lumo twice for the document (#16243) (#16257)

    * fix: Do not import Lumo twice for the document
    
    All Lumo modules except utility are loaded and injected into <head> by https://github.com/vaadin/flow-components/blob/main/vaadin-lumo-theme-flow-parent/vaadin-lumo-theme-flow/src/main/java/com/vaadin/flow/theme/lumo/Lumo.java
    We should not do that another time
    
    * Update flow-server/src/main/resources/plugins/application-theme-plugin/theme-generator.js
    
    
    
    ---------
    
    Co-authored-by: Artur <artur@vaadin.com>
    Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
    3 people authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    29259ea View commit details
    Browse the repository at this point in the history
  2. feat: support ES-module applications (#16207) (#16258)

    * Change extensions to cjs and fix imports
    
    * Rename in vite.generated.ts
    
    * Undo most changes
    
    * Use createRequire
    
    * Add comments
    
    Co-authored-by: Luciano Vernaschi <cromoteca@users.noreply.github.com>
    vaadin-bot and cromoteca authored Mar 14, 2023
    Configuration menu
    Copy the full SHA
    d633293 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. chore: remove the enforceFieldValidation feature flag (#16248) (CP: 2…

    …4.0) (#16262)
    
    * chore: remove the enforceFieldValidation feature flag (#16248)
    
    * fix errors after rebase
    vursen authored Mar 15, 2023
    Configuration menu
    Copy the full SHA
    6ee0214 View commit details
    Browse the repository at this point in the history
  2. refactor: Add mode enum to make code easier to read (#16225) (#16259)

    Co-authored-by: Artur <artur@vaadin.com>
    vaadin-bot and Artur- authored Mar 15, 2023
    Configuration menu
    Copy the full SHA
    4511c13 View commit details
    Browse the repository at this point in the history
  3. fix: Apply parent theme located in project frontend folder (#16218) (…

    …CP: 24.0) (#16263)
    
    * fix: Apply parent theme located in project frontend folder (#16218)
    
    * fix: Apply parent theme located in project frontend folder
    
    * Clarifications in comments and info message
    
    * extract a new method for frontend utils setup
    
    * fix version
    
    ---------
    
    Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
    Co-authored-by: Mikhail Shabarov <mikhail@vaadin.com>
    3 people authored Mar 15, 2023
    Configuration menu
    Copy the full SHA
    cb94028 View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. fix: Use correct scope for ee api's (#16223) (#16269)

    * Use correct scope for ee api's
    * fix tests
    * fix test (drags in also e.g. inject api that is needed for some tests)
    * fix serialization tests
    * added yet some jakarta apis for tests
    * local build is rather long now...
    * fix test
    * moved version to dependency management
    ---------
    Co-authored-by: Matti Tahvonen <matti@vaadin.com>
    Co-authored-by: Zhe Sun <31067185+ZheSun88@users.noreply.github.com>
    Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com>
    4 people authored Mar 16, 2023
    Configuration menu
    Copy the full SHA
    c949584 View commit details
    Browse the repository at this point in the history
  2. fix: Load badge when requested (#16286) (#16288)

    Fixes vaadin/platform#3916
    
    Co-authored-by: Artur <artur@vaadin.com>
    vaadin-bot and Artur- authored Mar 16, 2023
    Configuration menu
    Copy the full SHA
    e6a27e0 View commit details
    Browse the repository at this point in the history
  3. chore: optimize getModifierKey method, to handle more implementations…

    … of Key interface: (#16276) (#16281)
    
    * Make this code:
    .contains(new HashableKey(KeyModifier.ALT))
    	to work for more universal cases:
    .stream().anyMatch(key -> key.matches(Key.ALT.toString()));
    
    It should work now for HashableKeys and for other Key implementations as well.
    
    * Format the code and make it work for older Java versions as well.
    
    * As Key.Alt actually will be a collection of keys (key and additional keys), we need to look for the "Alt" itself.
    (Key ALT = Key.of("Alt", "AltLeft")
    
    Co-authored-by: czp13 <61667986+czp13@users.noreply.github.com>
    vaadin-bot and czp13 authored Mar 16, 2023
    Configuration menu
    Copy the full SHA
    f13df95 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. chore: Ensure usage stats is included in dev bundles (#16304) (#16313)

    Co-authored-by: Artur <artur@vaadin.com>
    vaadin-bot and Artur- authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    2b9d223 View commit details
    Browse the repository at this point in the history
  2. chore: Run dev bundle build in development mode (#16297) (CP: 24.0) (#…

    …16312)
    
    * chore: Run dev bundle build in development mode (#16297)
    
    * test: Delete nonsense test (#16300)
    
    (cherry picked from commit af49bf4)
    
    ---------
    
    Co-authored-by: Artur <artur@vaadin.com>
    vaadin-bot and Artur- authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    0a5f507 View commit details
    Browse the repository at this point in the history
  3. chore: Upgrade license-checker to 1.12.2 (#16310) (#16314)

    Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
    vaadin-bot and mshabarov authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    eee8099 View commit details
    Browse the repository at this point in the history
  4. test: Delete nonsense test (#16300) (#16317)

    Co-authored-by: Artur <artur@vaadin.com>
    vaadin-bot and Artur- authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    8cef32b View commit details
    Browse the repository at this point in the history
  5. chore(deps): bump maven-plugin-plugin from 3.7.1 to 3.8.1 (#16056) (#…

    …16320)
    
    Bumps [maven-plugin-plugin](https://github.com/apache/maven-plugin-tools) from 3.7.1 to 3.8.1.
    - [Release notes](https://github.com/apache/maven-plugin-tools/releases)
    - [Commits](apache/maven-plugin-tools@maven-plugin-tools-3.7.1...maven-plugin-tools-3.8.1)
    
    ---
    updated-dependencies:
    - dependency-name: org.apache.maven.plugins:maven-plugin-plugin
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    vaadin-bot and dependabot[bot] authored Mar 20, 2023
    Configuration menu
    Copy the full SHA
    f456489 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2023

  1. fix: Always set development mode when in development mode (#16330) (#…

    …16331)
    
    Co-authored-by: Artur <artur@vaadin.com>
    vaadin-bot and Artur- authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    179f753 View commit details
    Browse the repository at this point in the history
  2. chore: Throw an exception when a download fails (#16337) (#16339)

    Makes it easier to understand that download of Node failed instead of that the archive was corrupt
    
    Co-authored-by: Artur <artur@vaadin.com>
    vaadin-bot and Artur- authored Mar 21, 2023
    Configuration menu
    Copy the full SHA
    eaeaf87 View commit details
    Browse the repository at this point in the history
Loading