Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vaadin/flow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 23.1.3
Choose a base ref
...
head repository: vaadin/flow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 23.1.4
Choose a head ref
  • 14 commits
  • 65 files changed
  • 6 contributors

Commits on Jul 11, 2022

  1. fix: always generate themes in frontend 'generated' directory subfold…

    …er (#14144) (CP: 23.1) (#14155)
    
    Forces generated themes files to be stored in 'generated' folder under
    frontend directory, instead of using the 'generatedTsFolder' setting.
    Also fixes relative paths assuming frontend directory to be './frontend',
    and maven and gradle plugins to clean the 'frontendDirectory/generated' folder.
    
    Fixes #12880
    vaadin-bot authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    9f545e5 View commit details
    Browse the repository at this point in the history
  2. chore: Upgrade Node to 16.16 and npm to 8.11 (#14153) (#14159)

    Co-authored-by: Artur <artur@vaadin.com>
    vaadin-bot and Artur- authored Jul 11, 2022
    Configuration menu
    Copy the full SHA
    402aaed View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2022

  1. fix: Let DataCommunicator#flush keep track of which StateTree is supp…

    …osed to execute its flushRequest (#14068) (#14188)
    
    DataCommunicator#flush can be stuck when moving between UI instances, for instance when the @PreserveOnRefresh annotation is present.
    vaadin-bot authored Jul 20, 2022
    Configuration menu
    Copy the full SHA
    0dc4260 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2022

  1. feat: allow disabling validation status change listener registration …

    …on binder (#14197)
    
    Add binder-level flag to allow disabling of 
    validation status change listener registration 
    for HasValidator fields.
    
    Related to #13940 (comment) and #13940 (comment)
    
    Co-authored-by: Knoobie <Knoobie@gmx.de>
    vaadin-bot and knoobie authored Jul 21, 2022
    Configuration menu
    Copy the full SHA
    8083333 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. fix: Fix ServiceWorker path requests in dev mode (#14151) (#14203)

    Fixes: #13987
    
    Co-authored-by: Soroosh Taefi <taefi.soroosh@gmail.com>
    Co-authored-by: Marco Collovati <marco@vaadin.com>
    3 people authored Jul 22, 2022
    Configuration menu
    Copy the full SHA
    47c7287 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2022

  1. fix: make Vite work with custom frontend directory (#14152) (CP: 23.1) (

    #14222)
    
    Fixes Vite configuration to work with a custom frontend directory.
    Also rewrite theme css to resolve urls for assets defined in theme.json
    
    Fixes #14046
    Fixes #14102
    vaadin-bot authored Jul 26, 2022
    Configuration menu
    Copy the full SHA
    f827649 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Configuration menu
    Copy the full SHA
    db18533 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2022

  1. fix: build the service worker without writing it to FS (#14182) (#14229)

    Prevents restart of application during startup.
    
    Fixes #13123
    Fixes #14022
    Fixes #14146
    
    Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
    
    (cherry picked from commit d391029)
    
    Co-authored-by: Marco Collovati <marco@vaadin.com>
    mshabarov and mcollovati authored Jul 28, 2022
    Configuration menu
    Copy the full SHA
    8a17462 View commit details
    Browse the repository at this point in the history
  2. fix: provide correct devMode flag to theme-generator with Vite (#14230)…

    … (#14231)
    
    devMode flag was hard-coded to false in theme options, preventing the theme generator
    plugin to work correctly when styles.css does not exist
    
    Fixes #14228
    vaadin-bot authored Jul 28, 2022
    Configuration menu
    Copy the full SHA
    be28afc View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. fix: support import without url keyword in theme generator (#14234) (#…

    …14243)
    
    With Vite it may happend that '@import url(...)' in CSS are rewritten
    as '@import ...', that is a valid CSS statement.
    Currently the theme generator does not handle the case and this prevents
    the resource to be added to the head section. A warning is also
    logged on browser console, stating import rules not allowed when
    creating stylesheets.
    This change updates the importMatcher regex to handle @import without url
    
    Co-authored-by: Marco Collovati <marco@vaadin.com>
    vaadin-bot and mcollovati authored Aug 1, 2022
    Configuration menu
    Copy the full SHA
    2c44d33 View commit details
    Browse the repository at this point in the history
  2. fix: handle duplicated root entries in manifest (#14237) (#14244)

    Duplicated root entry in manifest happens when running application
    in development mode but after a frontend build.
    This change removes the entry potentially added by flow
    if compile-time manifest already added it
    
    Co-authored-by: Marco Collovati <marco@vaadin.com>
    vaadin-bot and mcollovati authored Aug 1, 2022
    Configuration menu
    Copy the full SHA
    b5780b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. fix: Not show warning if no poll listener (#14236) (#14250)

    * fix: Not show warning if no poll listener
    
    Fixes #14136
    
    Co-authored-by: Mikhail Shabarov <61410877+mshabarov@users.noreply.github.com>
    vaadin-bot and mshabarov authored Aug 2, 2022
    Configuration menu
    Copy the full SHA
    52d45eb View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. fix: let Vite process theme also on theme.js changes (#14257) (#14258)

    Flow theme plugin for Vite processes themes only on changes on files
    in active theme directory.
    This preventes regeneration with java live reload when changing value of
    Theme annotation.
    This change triggers theme processing also for updates on theme.js file.
    
    Co-authored-by: Marco Collovati <marco@vaadin.com>
    vaadin-bot and mcollovati authored Aug 3, 2022
    Configuration menu
    Copy the full SHA
    7b64c96 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. fix: handle theme files creation and deletion with Vite (#14260) (#14262

    )
    
    Vite 'handleHotUpdate' hook is invoked only for file changes, not for creation nor deletion.
    This change adds a watcher as well for those events and triggers theme regeneration
    when theme file are added or deleted
    
    Fixes #12154
    vaadin-bot authored Aug 4, 2022
    Configuration menu
    Copy the full SHA
    7bce822 View commit details
    Browse the repository at this point in the history
Loading